How to handle finished PR review threads

Just a quickie. We currently have a bunch of PR review threads sitting open for PRs that have been merged/closed, with no clear way to distinguish these from the open discussions.

  • Tag them
  • Make a subcategory

@lead-maintainers

We can do what we did with the old system and change the title of them / lock them.

1 Like

Yeah I’d handle it like you do Ban appeals, Lock the thread, give it the Merged/Closed tagg and call it a day.

This creates a ton of visual noise and is a bad solution. We have a proper forum software, we don’t need to do this.

I guess a solution similarly to Staff Complaints can be done where there are sub-categories for “done” and “rejected”, only in this case it would be categories for “Resolved” and “In-Progress”.
I am somewhat concerned about the fact that Discourse displays all posts of the sub categories when viewing the “parent” category, which still makes the “visual noise”. Can that be turned off?

Yeah, it can be. Development has it turned off for example.

That said, I’m cooking so maybe tags is fine:


That looks neat.

Deployed the CSS. Let’s see if this is good enough.

1 Like

We might want to change up the tags a little, as the forms are primarily for voting. We have some PRs that have voting concluded, yet are still open (awaiting code review).

Might be good to have tags for designating no-vote, ongoing, and finalized votes. That way maintainers who check in to the voting category can see what needs their attention.