master ← slarticodefast:refactor-remove-reagent-api
opened 09:03PM - 28 Jul 25 UTC
## About the PR
`SharedSolutionContainerSystem` API change.
Currently `RemoveR… eagent` just returns a bool indicating if any reagent amount was removed.
This was changed to instead return the removed amount to mirror the `Solution` API in [Solution.cs](https://github.com/space-wizards/space-station-14/blob/master/Content.Shared/Chemistry/Components/Solution.cs).
This allows us to check the removed amount without having to rely on low-level solution API methods, which is preferable as the `SolutionContainer` methods also do other updates for the solution entity visuals and dirty it.
The previous functionality can easily be re-obtained by checking if the returned amount is larger than zero.
## Why / Balance
Needed for https://github.com/space-wizards/space-station-14/pull/39079
## Technical details
The return value is not used anywhere in our codebase, so there are no systems that need to be fixed.
## Requirements
- [x] I have read and am following the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html).
- [x] I have added media to this PR or it does not require an ingame showcase.
## Breaking changes
`SharedSolutionContainerSystem.RemoveReagent` now returns the removed reagent amount as a `FixedPoint2` instead of a bool. If you need the previous behavior just compare the return value with `FixedPoint2.Zero`.
**Changelog**
not player facing
[Breaking Changes]SharedSolutionContainerSystem.RemoveReagent now returns the removed reagent amount as a FixedPoint2 instead of a bool. If you need the previous behavior just compare the return value with FixedPoint2.Zero.