Puddle Code Slipping Cleanup

EmoGarbage404 · April 30, 2025, 7:52pm

github.com/space-wizards/space-station-14

Puddle Code Slipping Cleanup

space-wizards:master ← Pronana:puddle-code

opened 06:36AM - 15 Mar 25 UTC

## About the PR Completely revamped the slipping logic of puddle code and how r…eagents determine they are slippery. Puddles can now also inherit and mix slippery data values like stun time, launch multiplier, and minimum speed before slipping This means a pure puddle of lube is more effective than a diluted one, and a puddle of water diluted with ketchup for example will be less slippery. I've also made it so that the effects on tile friction aren't hard-coded and are based on the contents of the puddle, this was needed for prediction but it also means that you can throw items on space lube and they will slide across it. ## Why / Balance Puddle code stood in the way between me and making a knockdown state PR so I had to vanquish it. Also the changes to puddle logic make intuitive sense, I see people try to dilute lube puddles with water all the time only for it to fail completely so this is for them. Also changes puddle logic so it updates tile friction based on how slippery it is. It was a flat friction change before that didn't care about what was even in the puddle and I'm not even sure if it ever *removed* that change to tile friction. Now it does! Fixes some bugs too!!! ## Technical details Cleaned up puddle code to reduce warnings Completely revamped how puddles determine if they are slippery Changed how puddles affect tile friction Changed data structure for SlipperyComponent to use SlipperEffectEntry in a field called SlipperyData Made it so Reagents have a null field for SlipperyData named SlipperyEffectEntry A bunch of various data changes to avoid things breaking ## Media Media probably not needed. I do have one video demonstrating the changes to friction though. https://github.com/user-attachments/assets/db51bf06-b2a3-48ef-acf3-d1314b8ebe82 ## Requirements - [X] I have read and am following the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html). - [X] I have added media to this PR or it does not require an ingame showcase. ## Breaking changes Reagents no longer have a bool for being slippery, they use the new Data Entry SlipperyEffectEntry named SlipData **Before:** - slippery: True **After** - slippery: paralyzeTime: 1.5 launchForwardsMultiplier: 1.5 requiredSlipSpeed: 3.5 superSlippery: false SlipperyEffectEntry stores data for stun times, launch multiplier, superslippery bool, and minimum slip speed SlipperyComponent now stores data for Stuns in SlipData which is a SlipperyEffectEntry **Before:** - type: slippery paralyzeTime: 1.5 launchForwardsMultiplier: 1.5 **After:** - type: slippery slipData: - paralyzeTime: 1.5 - launchForwardsMultiplier: 1.5 Two Tile Reactions: SpillTileReaction and SpillIfPuddleTileReaction were made obselete and removed A bunch of hardcoded values were removed from PuddleSystem **Changelog**  :cl: Princess Cheeseballs - add: Items now slip on slippery surfaces - tweak: Puddle slipperiness has been tweaked to be more intuitive

Reagents no longer have a bool for being slippery, they use the new Data Entry SlipperyEffectEntry named SlipData

Before:

  slippery: True

After

  slippery:
    paralyzeTime: 1.5
    launchForwardsMultiplier: 1.5
    requiredSlipSpeed: 3.5
    superSlippery: false

SlipperyEffectEntry stores data for stun times, launch multiplier, superslippery bool, and minimum slip speed

SlipperyComponent now stores data for Stuns in SlipData which is a SlipperyEffectEntry

Before:

- type: slippery
  paralyzeTime: 1.5
  launchForwardsMultiplier: 1.5

After:

- type: slippery
  slipData:
  - paralyzeTime: 1.5
  - launchForwardsMultiplier: 1.5

A bunch of hardcoded values were removed from PuddleSystem