[REVERTED] Biome rework

EmoGarbage404 · July 3, 2025, 1:51pm

github.com/space-wizards/space-station-14

Biome rework

master ← metalgearsloth:2025-05-05-biome-rework

opened 01:41AM - 23 May 25 UTC

Reworks biome code to use dungeons and is pretty much entirely rewritten. Advant…age is that we get to use cpujob now and makes biomes a lot more flexible and reduces code burden of maintenance. ## Breaking changes - Biomes have been entirely reworked and need porting to dungeons via the SampleEntity / SampleTile / SampeDecal layers. Standard biomes should be easy to port but if you're using marker layers that will take a bit more work to get off the ground. - Dungeons have had a bunch of changes around inheritance for reserved tiles across layers to make them more flexible and also namespace changes to standardise them. - Fixed AllTiles not including CorridorExteriorTiles. Review: - I checked asteroids + scrap and they seemed okay. - I flew around and it seems okayTM. - Ore layers always persist as they modify entities live so not entirely sure how to solve this one. - Expeds are probably broken in some way but we want to remove them anyway so eh? - It should be a lot easier for admins to add stuff dynamically. Random notes: - Adding layers at runtime should be a lot easier as it's just a dungeonconfig (entirely yaml) + console command. Using the layer string as a hash for the seed also helps with adding repeat layers (e.g. to spam ores or the likes). - Loading in large chunks takes a long-ass time so need to probably optimise it or potentially re-think it in future. At least biomes using dungeons means we can focus effort + QOL on one area and not two. - Expeds are probably broken in some way but we intend to remove them, I just didn't do it in this PR.

Biomes have been entirely reworked and need porting to dungeons via the SampleEntity / SampleTile / SampeDecal layers. Standard biomes should be easy to port but if you’re using marker layers that will take a bit more work to get off the ground.
Dungeons have had a bunch of changes around inheritance for reserved tiles across layers to make them more flexible and also namespace changes to standardise them.
Fixed AllTiles not including CorridorExteriorTiles.

Slartibartfast · July 4, 2025, 1:43am

This PR has been reverted due to critical bugs.

github.com/space-wizards/space-station-14

World Generation overlaps with the Arrivals terminal

opened 03:13PM - 03 Jul 25 UTC

closed 06:48PM - 03 Jul 25 UTC

Kowlin

S: Untriaged P0: Critical

## Description With the merge of #37735, Arrivals terminal are now filled with p…lanet generated junk like rock walls, trees, water rivers, and... Plasma rivers, that one is a fun one! **Reproduction** Run the server with #37735 merged into the code. **Screenshots** ![Image](https://github.com/user-attachments/assets/9aa5ea56-804b-4056-b639-d7dffa63769f) **Additional context** N/A

github.com/space-wizards/space-station-14

The biome rework is crashing vulture

opened 12:45PM - 03 Jul 25 UTC

closed 02:44PM - 03 Jul 25 UTC

slarticodefast

T: Bugfix A: Core Tech P0: Critical

Caused by https://github.com/space-wizards/space-station-14/pull/37735 ``` Caug…ht exception in entsys Robust.Shared.GameObjects.EntityCreationException: Exception inside InitializeAndStartEntity ---> Robust.Shared.Prototypes.UnknownPrototypeException: Unknown EntityPrototype prototype: BiomeContinental at Robust.Shared.Prototypes.PrototypeManager.Index[T](String id) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/Prototypes/PrototypeManager.cs:line 258 at Content.Server.Gateway.Systems.GatewayGeneratorSystem.GenerateDestination(EntityUid uid, GatewayGeneratorComponent generator) in /home/runner/work/space-station-14/space-station-14/Content.Server/Gateway/Systems/GatewayGeneratorSystem.cs:line 93 at Content.Server.Gateway.Systems.GatewayGeneratorSystem.OnGeneratorMapInit(EntityUid uid, GatewayGeneratorComponent generator, MapInitEvent args) in /home/runner/work/space-station-14/space-station-14/Content.Server/Gateway/Systems/GatewayGeneratorSystem.cs:line 87 at Robust.Shared.GameObjects.EntityEventBus.RaiseLocalOrdered(EntityUid uid, Type eventType, EventData subs, Unit& unitRef, Boolean broadcast) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Ordering.cs:line 43 at Robust.Shared.GameObjects.EntityEventBus.RaiseLocalEvent[TEvent](EntityUid uid, TEvent args, Boolean broadcast) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Directed.cs:line 200 at Robust.Shared.GameObjects.EntityManager.InitializeAndStartEntity(Entity`1 entity, Boolean doMapInit) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityManager.cs:line 954 --- End of inner exception stack trace --- at Robust.Shared.GameObjects.EntityManager.InitializeAndStartEntity(Entity`1 entity, Boolean doMapInit) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityManager.cs:line 959 at Content.Server.Station.Systems.StationSystem.InitializeNewStation(StationConfig stationConfig, IEnumerable`1 gridIds, String name) in /home/runner/work/space-station-14/space-station-14/Content.Server/Station/Systems/StationSystem.cs:line 344 at Content.Server.Station.Systems.StationSystem.OnPostGameMapLoad(PostGameMapLoad ev) in /home/runner/work/space-station-14/space-station-14/Content.Server/Station/Systems/StationSystem.cs:line 166 at Robust.Shared.GameObjects.EntityEventBus.ProcessSingleEventCore(EventSource source, Unit& unitRef, EventData subs) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Broadcast.cs:line 335 at Robust.Shared.GameObjects.EntityEventBus.RaiseEvent[T](EventSource source, T toRaise) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Broadcast.cs:line 275 at Content.Server.GameTicking.GameTicker.LoadMaps() in /home/runner/work/space-station-14/space-station-14/Content.Server/GameTicking/GameTicker.RoundFlow.cs:line 93 at Content.Server.GameTicking.GameTicker.UpdateRoundFlow(Single frameTime) in /home/runner/work/space-station-14/space-station-14/Content.Server/GameTicking/GameTicker.RoundFlow.cs:line 784 at Content.Server.GameTicking.GameTicker.Update(Single frameTime) in /home/runner/work/space-station-14/space-station-14/Content.Server/GameTicking/GameTicker.cs:line 133 at Robust.Shared.GameObjects.EntitySystemManager.TickUpdate(Single frameTime, Boolean noPredictions) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntitySystemManager.cs:line 318 Catcher=entsys Sawmill=runtime ``` Why the hell is this a non-validated hardcoded string? ![Image](https://github.com/user-attachments/assets/ec6f4199-624d-4977-ac04-175d7eca674d)