Stunnable New Status and Cleanup #38618

ScarKy0 · July 21, 2025, 5:23pm

github.com/space-wizards/space-station-14

Stunnable New Status and Cleanup

master ← Princess-Cheeseballs:stunnable-new-status-and-cleanup

opened 07:20AM - 27 Jun 25 UTC

## About the PR Helps with: #38575 Requires: #38617 Requires: #38660 Proj…ect Zero warnings PR basically. Cleaned up every warning in Stunnable and moved Stun and Knockdown to New Status Moved SlowedDown to its own system in Movement and updated it to the new status system. Got rid of a number of miscellaneous warnings in areas I was touching anyways. Should be compatible with: #36881 (Although I'll have to eat some fat merge conflicts) ## Why / Balance Warnings bad, new status good. New status good, warnings bad. ## Technical details - Converted Stunnable Statuses to new status system - Moved all the slowdown stuff to a new system called the MovementModStatusSystem - Fixed a bug with Stamina Slowdown where it could delete other slowdown modifiers - Fixed a bug with paralysis where it wouldn't stun if the entity was knockdown immune, but would knockdown even if the entity was stun immune - Cleaned up every other warning I saw in SharedStunSystem - CanAddStatusEffect has been moved to public. - Changed SleepingComponents a bit to be compatible with stun and not have either ended early - TryUpdateStatusEffect now accepts a bool "refresh" which lets you choose if you want to choose the greater time or add time. ## Media ## Requirements - [X] I have read and am following the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html). - [X] I have added media to this PR or it does not require an ingame showcase. ## Breaking changes TrySlowdown and relevant components have been moved to MovementModStatusSystem in the Movement folder. TrySlowdown has had its refresh bool moved to the end of the component to match how other status effects work. TrySlowdown has been renamed to TryModMovement. **Changelog** no cl no fun

[Breaking Changes]
SharedStunSystem.TryStun and TryKnockdown was replaced with TryAddStunDuration, TryUpdateStunDuration, TryAddKnockdownDuration and TryUpdateKnockdownDuration respectively, with reasoning of ‘refresh’ flag not providing clear and readable intention when methods are called.

MovementModStatusSystem.TryFriction was replaced with TryAddMovementSpeedModDuration and TryUpdateMovementSpeedModDuration.

SharedStunSystem.TrySlowdown migrated to MovementModStatusSystem and was splitted into TryAddMovementSpeedModDuration and TryUpdateMovementSpeedModDuration. Now slow down effects (that are used by MovementModStatusSystem) are having multiplicative effect between them and are based on effect prototypes, which are currently mostly created per slowdown ‘source’.

Reminder, that with new system, Add methods plainly add duration value to status effect, and Update sets duration to greater value between provided to method and current (will not override value with lower).