master ← Tayrtahn:cleanup/shared-biome-system
opened 09:29PM - 21 May 25 UTC
## About the PR
Updates various methods in `SharedBiomeSystem` to take in an … `Entity<MapGridComponent>` instead of just a `MapGridComponent`. This allows for the cleanup of two warnings in `SharedBiomeSystem`. This PR also fixes 2 unrelated warnings in `BiomeSystem`.
## Why / Balance
https://github.com/space-wizards/space-station-14/issues/33279
## Technical details
- `TryGetBiomeTile`, `TryGetTile`, `TryGetEntity`, and `TryGetDecals` were given new overloads that use `Entity<MapGridComponent>?` as parameters where the old versions used `MapGridComponent?`.
- The old versions were marked as obsolete to avoid breaking changes.
- All uses of the now-obsolete versions in Content were updated to use the new versions.
- Additionally, two obsolete method calls in `BiomeSystem` were updated to use appropriate `MapSystem` methods.
## Requirements
- [X] I have read and am following the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html).
- [X] I have added media to this PR or it does not require an ingame showcase.
## Breaking changes
The `SharedBiomeSystem` methods `TryGetBiomeTile`, `TryGetTile`, `TryGetEntity`, and `TryGetDecals` now take `Entity<MapGridComponent>?` as a parameter where the old versions used `MapGridComponent?`. The old versions have been marked as obsolete.
The SharedBiomeSystem methods TryGetBiomeTile, TryGetTile, TryGetEntity, and TryGetDecals now take Entity<MapGridComponent>? as a parameter where the old versions used MapGridComponent?. The old versions have been marked as obsolete.